[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [try 2] [2/2] mlang: Add implementation
From:       "Dmitry Timoshkov" <dmitry () codeweavers ! com>
Date:       2008-10-29 16:46:43
Message-ID: 6F40210E733440438A30911C7E1CBD0E () DMITRY
[Download RAW message or body]

"Vitaly Perov" <vitperov@etersoft.ru> wrote:

> "Vitaly Perov" <vitperov@etersoft.ru> wrote:
> 
>>> It doesn't really matter what code pages Windows supports, it does
>>> matter though what code pages are valid. You need to use Win32 APIs
>>> EnumSystemCodePages/GetCPInfo/MultiByteToWideChar instead of accessing
>>> Wine internals directly.
> 
>>I used EnumSystemCodePages before, but in this case GetCharCodePages set some 
>>extra bits in result. So the result differ from Windows

I can't read your mind or guess what those "some extra bits" are. Why can't you
mark the failing tests with todo_wine and think later how to make the tests pass?

>>> ... or rather use mlang internal mlang_data structures.
> 
>>I's good idea! Thank you!
> 
> So, I use mlang_data[i].family_codepage as you adviced.
> May be I misunderstood something?

Have you tried to do what I suggested?

Also you either need to send the test after the implementation, or add
todo_wine in appropriate places and remove them in the patch which makes
the tests pass.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]