[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: d3d8: Fix incorrect ordering of brackets in
From:       "Rob Shearman" <robertshearman () gmail ! com>
Date:       2008-09-30 15:00:54
Message-ID: 1096648c0809300800w2b7c5abcxfb99f1d74073b6e () mail ! gmail ! com
[Download RAW message or body]

2008/9/30 Henri Verbeet <hverbeet@gmail.com>:
> 2008/9/30 Rob Shearman <robertshearman@gmail.com>:
>> The comparison should be (D3D_OK == hr && myDevice), not (D3D_OK ==
>> (hr && myDevice)).
>>
> d3d8 and d3d9 are pretty bad at stuff like this, unfortunately.
> Strictly speaking we should also compare to WINED3D_OK instead of
> D3D_OK here, but they have the same values.

Ok, I will fix that in my patches and resend.

-- 
Rob Shearman


[prev in list] [next in list] [prev in thread] [next in thread]