[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: What does patchwatcher do?
From:       "Dan Kegel" <dank () kegel ! com>
Date:       2008-08-30 14:08:54
Message-ID: a71bd89a0808300708l22fa0f7fy45daa8e21ce89790 () mail ! gmail ! com
[Download RAW message or body]

On Sat, Aug 30, 2008 at 2:13 AM, Rico Schüller <kgbricola@web.de> wrote:
> My patch let the ddraw:d3d.c crash on wine (search for "0x60e52ad9
> IWineD3DBaseSwapChainImpl_GetBackBuffer" in the log
> (http://kegel.com/wine/patchwatcher/results/274.log)). So it isn't in the
> blacklist and shouldn't be there. The problem here is that my patch breaks
> the test (the test crashes) but the patchwatcher didn't recognize it.

OK, looks like patchwatcher needs to also recognize lines like
make[XXX]: *** [XXX.ok] Error XXX
instead of relying on just messages from test.h.
I'll try to fix that this weekend.

Thanks,
Dan



[prev in list] [next in list] [prev in thread] [next in thread]