[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: mpr: Improve stubs for WNetGetUniversalName.
From:       "James Hawkins" <truiken () gmail ! com>
Date:       2008-08-28 23:56:59
Message-ID: 22821af30808281656r22aa2bd4w75e0fc6450d48abb () mail ! gmail ! com
[Download RAW message or body]

On Thu, Aug 28, 2008 at 6:52 PM, Sergey Khodych <khodych@gmail.com> wrote:
> James Hawkins wrote:
>>
>> There are several things wrong with this patch:
>> * It's way too large.  Please split it up.
>> * No tests.  You need to write tests to back up these changes.
>
> Are tests necessary for simple stubs? I don't know what kind of
> tests can be written for stubs, except tests for wrong input parameters.
>

Your changes move the functions out of the realm of simple stubs.

-- 
James Hawkins


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic