[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: resend: kernel32: modify DeleteFile to fail on directories
From:       "Vincent Povirk" <madewokherd+8cd9 () gmail ! com>
Date:       2008-08-28 23:34:55
Message-ID: ced95fe0808281634t41622550q9701b9f56e4b03f4 () mail ! gmail ! com
[Download RAW message or body]

I think you should avoid the GetFileAttributes call. It adds extra
steps (including potentially an extra case-insensitive lookup), and
the file attributes could change between that call and NtDeleteFile.

It seems like it should be possible to do this without forcing ntdll
to search for the file multiple times.

Vincent Povirk



On Thu, Aug 28, 2008 at 8:57 AM, Jeff Zaroyko <jeffzaroyko@gmail.com> wrote:
> combining everything in one patch as Paul Vriens suggested, probably
> makes more sense.
>
> -Jeff
>
>
>
>


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic