[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: shell32/tests: Add test for SHFileOperation [resend]
From:       "James Hawkins" <truiken () gmail ! com>
Date:       2008-06-29 18:11:32
Message-ID: 22821af30806291111s167b2fam1927cafd28f28362 () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jun 29, 2008 at 5:16 AM, Vitaly Perov <vitperov@etersoft.ru> wrote:
>> You didn't set the FOF_MULTIDESTFILES flag.
>
> I use &shfo2. In shfo2 this flag is always set.
>

Don't make assumptions in the tests; it makes them harder to read.
Why don't you put the test right below the exact same test that
doesn't have the FOF_MULTIDESTFILES flag set (like I said before)?
It's more logical and shows exactly what behavior you're comparing in
the tests.

-- 
James Hawkins


[prev in list] [next in list] [prev in thread] [next in thread]