[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Fix debug log incosistencies and function naming
From:       Vitaliy Margolen <wine-devel () kievinfo ! com>
Date:       2008-05-31 20:27:17
Message-ID: 4841B4A5.8090705 () kievinfo ! com
[Download RAW message or body]

Michael Karcher wrote:
> Debugging DirectDraw reference counting is confusing,
> as the IDirectDraw{,2,3,4}_AddRef methods dump to ddraw_thunk,
> whereas the matching Release methods dump to ddraw. This
> patch changes to consistently use the ddraw channel.
> 
> Furthermore, as the methods from IDirectDraw7 are named
> like "IDirectDrawImpl_Foo", the functions from IDirectDraw
> (Direct Draw 1) get renamed to "IDirectDraw1Impl_Foo" to
> avoid non-unique function names in trace logs.
> ---

Please make it two patches. One to change debug channel. Second to rename 
IDirectDrawImpl into IDirectDraw1Impl.

Vitaliy.


[prev in list] [next in list] [prev in thread] [next in thread]