[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Fixing crashes in Tests (OS version check)
From:       "Juan Lang" <juan.lang () gmail ! com>
Date:       2008-05-31 18:51:51
Message-ID: 3a768c550805311151h77f6a138y65a95e6716510f3e () mail ! gmail ! com
[Download RAW message or body]

> An example of one that fails is
> ret = SnmpUtilOidToA(NULL);
> Under win98, this function is valid to call, but will crash if you call
> it will a NULL parameter.  I don't think removing this test a good idea,
> since we are setting XP as a base, at this passes.

I disagree that the test shouldn't be removed.  The tests are meant to
show Windows behavior that apps are likely to expect.  Since the apps
will crash if they pass NULL to SnmpUtilOidToA, it's reasonable to
expect that they will not.  Unless there's an app that depends on
being able to do so, removing the test seems more sensible as it means
we'll get better test coverage on Win98.

--Juan


[prev in list] [next in list] [prev in thread] [next in thread]