[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: user32: Allow a NULL foreground window in the tests
From:       "Dmitry Timoshkov" <dmitry () codeweavers ! com>
Date:       2008-05-30 1:24:31
Message-ID: 1BA927F352D3457BBB7BEDA210AFEE73 () DMITRY
[Download RAW message or body]

"James Hawkins" <truiken@gmail.com> wrote:

> Passing 0 for the foreground window essentially disables the test,
> whereas allowing a NULL window is testing another variation of what
> can happen with the foreground window, just like if a last error is,
> e.g.,  ERROR_FILE_NOT_FOUND on one platform instead of
> ERROR_PATH_NOT_FOUND.  Your method disables the test completely.

Yes, passing foreground == 0 disables the foreground window test. That
should be done very carefully for the tests that always fail. I'd expect
for instance test_SetActiveWindow() and test_SetForegroundWindow() not
need to disable it.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]