[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [resend] [Try 4] [1/2] cabinet.dll -> FDICopy: Test added
From:       "James Hawkins" <truiken () gmail ! com>
Date:       2008-04-29 15:52:38
Message-ID: 22821af30804290852s1808cab1i666b9ec5f8ab288f () mail ! gmail ! com
[Download RAW message or body]

2008/4/29 Vitaly Perov <vitperov@etersoft.ru>:
> jhawkins@codeweavers.com : cabinet: Revert "cabinet: Fix for FDICopy with an
>  empty cabinet file."
>  > Hi,
>  >
>  >  The test was incorrect and failed on all platforms.  Vitaly, please
>  >  ask someone to test your patches on a real windows system in the
>  >  future if you don't have access to one.
>
>  I have tested this patch on Win98. It didn't failed.
>  But on WinXP it failed.
>
>  The pach comes with this test fix a problem, so installation of certain
>  software (it includes one empty cab-file ) doesn't fail anymore.
>  I don't think, that this patch can cause any problem with a software developed
>  for WinXP.
>
>  So, please look it trough once more.
>

Just look at the test results:

http://test.winehq.org/data/200804252248/

It fails on every single platform, including win98.

-- 
James Hawkins


[prev in list] [next in list] [prev in thread] [next in thread]