[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: Re: user32: Implement BroadcastSystemMessage, try 5.1
From: "Maarten Lankhorst" <m.b.lankhorst () gmail ! com>
Date: 2008-03-31 18:54:53
Message-ID: b130c85e0803311154s6b59dd8cx60964f44d80b3fe0 () mail ! gmail ! com
[Download RAW message or body]
Hello Alexandre,
2008/3/31, Alexandre Julliard <julliard@winehq.org>:
> Vitaliy Margolen <wine-devel@kievinfo.com> writes:
>
>
> > But that's the thing. How can you definitively say that there isn't a
> > program that affected by this?
>
>
> Of course you can never be certain, but after having debugged a number
> of apps, and checked the behavior of APIs across Windows versions, there
> are things that you know do matter, and things that don't; and the last
> error behavior on success is definitely in the latter category.
>
> Yes, I'm sure someone someday can find a case where some specific app
> depends on some specific function to handle last error in a different
> way; but there's no reason to believe that BroadcastSystemMessage is
> more likely to trigger that bug than any other of the 10,000 functions
> that touch last error. So we either wait until we find an app that
> depends on this and fix the one offending function, or we spend months
> adding ugly code to every single API; adding the ugly code to only a
> handful of randomly chosen functions doesn't make any sense.
Ok, I'll remove the last error tests where they don't matter then once
I clean up my git tree a little, there's too much stuff lying around
at the moment. :-)
Cheers,
Maarten.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic