[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: msi: ACTION_RegisterProduct store all InstallProperties
From:       "James Hawkins" <truiken () gmail ! com>
Date:       2008-02-29 17:39:57
Message-ID: 22821af30802290939q489b73d9n3c9c106604a49e8c () mail ! gmail ! com
[Download RAW message or body]

On Fri, Feb 29, 2008 at 9:13 AM, Adam Strzelecki <ono@java.pl> wrote:
> Hi,
>
>  WINE is writing properties such as Language or VersionMajor only to
>  Uninstall key in ACTION_RegisterProduct, while MSI_GetProductInfo is
>  trying to read those from InstallProperties key.
>
>  So this patch duplicates all properties written into MSI product
>  Uninstall key, also to InstallProperies.
>  This is normal behavior I can see in Windows XP's MSI, as properties
>  are duplicated in both Uninstall and InstallProperties.
>

Please do not accept this patch.  I'm trying to clean up the
publishing code, and without tests to prove this case, it should not
go in.  The tests that do exist show that the properties are written
into the Uninstall key on RegisterProduct, but not the product key.

-- 
James Hawkins


[prev in list] [next in list] [prev in thread] [next in thread]