[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Alistair Leslie-Hughes : msvcrt: Implement wcscpy_s.
From:       James McKenzie <jjmckenzie51 () sprintpcs ! com>
Date:       2008-02-28 12:45:22
Message-ID: 47C6ACE2.1010807 () sprintpcs ! com
[Download RAW message or body]

Alexandre Julliard wrote:
> "James Hawkins" <truiken@gmail.com> writes:
>
>   
>> If you'll read the tests, you'll see that the first test is correct
>> (although it should really be >= and he should add a test for this).
>>     
>
> No, it shouldn't be >=, there's no reason to fail if the buffer is the
> same size as the data.
>
>   
The failure should be when the size of the data is more than the 
buffer.  I think that was the case for the first check.  The question 
was for the second chunk of code.  I think that it should have been less 
than.  If the size of the data and the size of the buffer are the same, 
no change to the size of the buffer is needed.

James McKenzie



[prev in list] [next in list] [prev in thread] [next in thread]