[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicode
From:       Alexander Nicolaysen =?iso-8859-1?q?S=F8rnes?= <alex () thehandofagony ! com>
Date:       2007-12-31 15:08:16
Message-ID: 200712311608.17066.alex () thehandofagony ! com
[Download RAW message or body]

On Monday 31 December 2007 07:39:28 Dmitry Timoshkov wrote:
> "Alexander Nicolaysen Sørnes" <alex@thehandofagony.com> wrote:
> > comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicod
>
> What's the purpose of this patch? It improves nothing IMO except of
> making the code less readable, making it not thread safe, calling
> CallWindowProcW where it shouldn't.


I made these changes so that the PageSetupDlgA/W could share the paper preview 
code, which the W variant currently doesn't have (preview added in patch 
2/2).

I would be grateful if you could suggest ways to improve the code, but if it's 
completely hopeless I'll accept that. :)


Alexander N. Sørnes



[prev in list] [next in list] [prev in thread] [next in thread]