[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [Patch] for wined3d: Correcting order issue
From:       "Vijay Kiran Kamuju" <infyquest () gmail ! com>
Date:       2007-11-30 15:58:33
Message-ID: 36bf289b0711300758x7c478e27lf14dd70a867f68e1 () mail ! gmail ! com
[Download RAW message or body]

On Nov 30, 2007 3:26 AM, Roderick Colenbrander <thunderbird2k@gmx.net> wrote:
> > Hi all,
> > 
> > This patch repairs my previous one, as the command never got executed,
> > because 8600 matches before 8600M.
> > 
> > 
> > Marco Schuster
> > 
> > ----
> > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c
> > index e4b5bdf..50b3250 100644
> > --- a/dlls/wined3d/directx.c
> > +++ b/dlls/wined3d/directx.c
> > @@ -950,6 +950,11 @@ BOOL IWineD3DImpl_FillGLCaps(WineD3D_GL_Info
> > *gl_info) {
> > gl_info->gl_card = CARD_NVIDIA_GEFORCE_8800GTS;
> > vidmem = 320; /* The 8800GTS uses 320MB, a 8800GTX
> > can have 768MB */
> > }
> > +                /* Geforce8 - midend mobile */
> > +                else if(strstr(gl_info->gl_renderer, "8600 M")) {
> > +                    gl_info->gl_card = CARD_NVIDIA_GEFORCE_8600MGT;
> > +                    vidmem = 512;
> > +                }
> > /* Geforce8 - midend */
> > else if(strstr(gl_info->gl_renderer, "8600") ||
> > strstr(gl_info->gl_renderer, "8700"))
> > @@ -957,11 +962,6 @@ BOOL IWineD3DImpl_FillGLCaps(WineD3D_GL_Info
> > *gl_info) {
> > gl_info->gl_card = CARD_NVIDIA_GEFORCE_8600GT;
> > vidmem = 256;
> > }
> > -                /* Geforce8 - midend mobile */
> > -                else if(strstr(gl_info->gl_renderer, "8600 M")) {
> > -                    gl_info->gl_card = CARD_NVIDIA_GEFORCE_8600MGT;
> > -                    vidmem = 512;
> > -                }
> > /* Geforce8 - lowend */
> > else if(strstr(gl_info->gl_renderer, "8300") ||
> > strstr(gl_info->gl_renderer, "8400") ||
> > 
> 
> I would prefer not to extend the list with lots of additional models. In my opinion \
> it isn't really needed as the list would become a lot longer and this makes it \
> harder to maintain. If we would continue this way we would easily have to add two \
> dozen additional mobile cards which are now handled as their desktop equivalents.

I Would rather have a registry entry for all the cards, and user can
add new cards. If they feel its not there. But I think this idea came
up quite a long back and was rejected in favor of in the code values.
Sorry for raising it up again.

-- VJ


[prev in list] [next in list] [prev in thread] [next in thread]