[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    re: wininet [1/2]: Add test for FtpGetCurrentDirectoryA
From:       "Dan Kegel" <dank () kegel ! com>
Date:       2007-11-29 13:49:54
Message-ID: a71bd89a0711290549x175fa2e4g1aadf9a56edd0af9 () mail ! gmail ! com
[Download RAW message or body]

Nice to see you contributing tests!
Three comments:
1. you seem to have ragged indentation.  Did you remember to remove all tabs?
(Hmm.  Our doc on the tab issue is a bit weak: neither
http://winehq.org/site/sending_patches
http://winehq.org/site/docs/winedev-guide/style-notes
really capture the current anti-tab mood.)
2. You have a nice testDir variable, but then you hard-code
"pub" somewhere.  Use the variable everywhere.
3. Did you make sure the new tests pass on Windows?

-- 
Wine for Windows ISVs: http://kegel.com/wine/isv


[prev in list] [next in list] [prev in thread] [next in thread]