[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ole32: Fix two comments in ok strings in the WdtpInterfacePointer
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2007-11-28 11:41:09
Message-ID: 87aboylhre.fsf () wine ! dyndns ! org
[Download RAW message or body]

Robert Shearman <rob@codeweavers.com> writes:

> diff --git a/dlls/ole32/tests/usrmarshal.c b/dlls/ole32/tests/usrmarshal.c
> index 9959f74..5819ec1 100644
> --- a/dlls/ole32/tests/usrmarshal.c
> +++ b/dlls/ole32/tests/usrmarshal.c
> @@ -801,9 +801,9 @@ static void test_marshal_WdtpInterfacePointer(void)
> wireip = buffer;
> if (size >= 28)
> {
> -        ok(*(DWORD *)wireip == 0x44, "wireip + 0x0 should be 0x4c instead of \
> 0x%08x\n", *(DWORD *)wireip); +        ok(*(DWORD *)wireip == 0x44, "wireip + 0x0 \
> should be 0x44 instead of 0x%08x\n", *(DWORD *)wireip); wireip += sizeof(DWORD);
> -        ok(*(DWORD *)wireip == 0x44, "wireip + 0x8 should be 0x4c instead of \
> 0x%08x\n", *(DWORD *)wireip); +        ok(*(DWORD *)wireip == 0x44, "wireip + 0x8 \
> should be 0x44 instead of 0x%08x\n", *(DWORD *)wireip);

While we are on the subject, why does it say wireip + 0x8 when the
pointer is incremented by 4?  The rest of the offsets are wrong too,
especially the iid comparison.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]