[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: winex11.drv[1/4]: wintab: restructure WTInfoA to dump a
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2007-08-31 18:23:48
Message-ID: 87myw7k1fv.fsf () wine ! dyndns ! org
[Download RAW message or body]

"Mikolaj Zalewski" <mikolajz@google.com> writes:

>   I see that my patch to skip non-pressure-sensitive devices didn't
> get it. I will try to look into it next week while now I'll resend the
> Unicode patches that are easier. Here the first patch could be
> controversial as I use a lot of macros. But that allows me not to use
> long parameter lists.

It's ugly. I don't see why you'd need long parameter lists at all,
simply adding a current offset in CopyTabletData should be enough.
Also, always going through all the cases even when a specific index is
specified is not nice. And the winex11 function should always return
Unicode, the A translation can be done in the generic code.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]