[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Patch: VarWeekdayName
From:       "Juan Lang" <juan.lang () gmail ! com>
Date:       2007-07-31 15:38:18
Message-ID: 3a768c550707310838y28fa8ed6w1d176006d6e4bb03 () mail ! gmail ! com
[Download RAW message or body]

Hi Jiri,

> I want to ask, is anything wrong with this patch?

Your indenting is haphazard.  Please match the indenting in the rest
of the file, which in this case is no tabs, 2-space indenting.  Also,
curly braces go on a new line, so e.g.:
+  if (!size) {
should be
+  if (!size)
+  {
instead.

--Juan


[prev in list] [next in list] [prev in thread] [next in thread]