[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: cabinent: add a comment about parm passing
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2007-06-28 9:38:05
Message-ID: 87bqf05shu.fsf () wine ! dyndns ! org
[Download RAW message or body]

Jeff L <lats@yless4u.com.au> writes:

> Mainly because the logic is a bit difficult.  It depends on the length
> being 0 to terminate the for loop and prevent the null reference.  It
> is not obvious and easily missed the first time through. Wine has a
> number of things like that and more comments would make it quicker and
> safer to works with.

No, the proper way is to fix the code so that it's understandable.
In this specific case you can get rid of the realloc function, it's
useless.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]