[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: RE: [PATCH try2 2/2] winemenubuilder: Wait for application icons to
From: "Koshelev, Misha Vladislavo" <mk144210 () bcm ! tmc ! edu>
Date: 2007-06-27 14:03:39
Message-ID: 10C24F7C4D05EB45B5F0E1B397897849010F7E59 () BCMEVS7 ! ad ! bcm ! edu
[Download RAW message or body]
--===============8975915570845759798==
Content-class: urn:content-classes:message
Content-Type: multipart/alternative;
boundary="----_=_NextPart_001_01C7B8C4.2C7F341C"
This is a multi-part message in MIME format.
> From: Alexandre Julliard [mailto:julliard@winehq.org]
> Sent: Wed 6/27/2007 8:42 AM
> To: Koshelev, Misha Vladislavo
> Cc: Hans Leidekker; wine-devel@winehq.org
> Subject: Re: [PATCH try2 2/2] winemenubuilder: Wait for application icons to be \
> created instead of adding a >RunOnce entry that may never run. Misha Koshelev \
> <mk144210@bcm.edu> writes:
> > Hmm... I was not aware of this (that means that make change.ok in
> > dlls/kernel32/tests fails on non-Linux systems?). What happens in these
> > other non-Linux systems... does FindFirstChangeNotification return
> > INVALID_HANDLE_VALUE or succeed and just never satisfy the wait
> > condition?
>
> It will never satisfy the wait. That can happen on older Linux kernels
> too, or on network file systems. You can't rely on change
> notifications, they are just a hint.
>
> > The good thing about the __wine_make_system_process wait we are also
> > waiting for is that it will get satisfied when all user processes have
> > closed and create links then as well. This is actually sufficient in
> > itself for some installers (Vector NTI), but not others that launch apps
> > while installing (iTunes). Perhaps I can add a long timeout to the wait
> > to account for these other non-Linux platforms...
>
> A better approach would probably be to simply wait for the parent
> process to exit.
Good point. This would probably avoid the __wine_make_system_process call altogether
too. Will resubmit again prob sometime tonight.
Misha
[Attachment #3 (text/html)]
<HTML dir=ltr><HEAD><TITLE>Re: [PATCH try2 2/2] winemenubuilder: Wait for application \
icons to be created instead of adding a RunOnce entry that may never run.</TITLE> \
<META http-equiv=Content-Type content="text/html; charset=unicode"> <META \
content="MSHTML 6.00.2900.3132" name=GENERATOR></HEAD> <BODY>
<DIV id=idOWAReplyText24307 dir=ltr>
<DIV dir=ltr><FONT face=Tahoma size=2><B>>From:</B> Alexandre Julliard \
[mailto:julliard@winehq.org]<BR><B>>Sent:</B> Wed 6/27/2007 8:42 \
AM<BR><B>>To:</B> Koshelev, Misha Vladislavo<BR><B>>Cc:</B> Hans Leidekker; \
wine-devel@winehq.org<BR><B>>Subject:</B> Re: [PATCH try2 2/2] winemenubuilder: \
Wait for application icons to be created instead of adding a >RunOnce entry that \
may never run.<BR></FONT><FONT size=2>>Misha Koshelev <mk144210@bcm.edu> \
writes:<BR>><BR>>> Hmm... I was not aware of this (that means that make \
change.ok in<BR>>> dlls/kernel32/tests fails on non-Linux systems?). What \
happens in these<BR>>> other non-Linux systems... does \
FindFirstChangeNotification return<BR>>> INVALID_HANDLE_VALUE or succeed and \
just never satisfy the wait<BR>>> condition?<BR>><BR>>It will never \
satisfy the wait. That can happen on older Linux kernels<BR>>too, or on network \
file systems. You can't rely on change<BR>>notifications, they are just a \
hint.<BR>><BR>>> The good thing about the __wine_make_system_process wait we \
are also<BR>>> waiting for is that it will get satisfied when all user \
processes have<BR>>> closed and create links then as well. This is actually \
sufficient in<BR>>> itself for some installers (Vector NTI), but not others \
that launch apps<BR>>> while installing (iTunes). Perhaps I can add a long \
timeout to the wait<BR>>> to account for these other non-Linux \
platforms...<BR>><BR>>A better approach would probably be to simply wait for \
the parent<BR>>process to exit.<BR></FONT></DIV> <DIV dir=ltr><FONT size=2>Good \
point. This would probably avoid the __wine_make_system_process call \
altogether</FONT></DIV> <DIV dir=ltr><FONT size=2>too. Will resubmit again prob \
sometime tonight.</FONT></DIV> <DIV dir=ltr><FONT size=2></FONT> </DIV>
<DIV dir=ltr><FONT size=2>Misha</DIV></FONT></DIV></BODY></HTML>
--===============8975915570845759798==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic