[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [ws2_32] getsockname should fail on unbound socket
From:       Kai Blin <kai.blin () gmail ! com>
Date:       2007-05-30 8:18:39
Message-ID: 200705301018.46949.kai.blin () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 30 May 2007 07:56:31 Damjan Jovanovic wrote:
> +        case AF_INET: {
> +            const struct sockaddr_in *in = (struct sockaddr_in*) uaddr;
> +            return in->sin_port != 0;
> +        }

Talking to Alexandre about this in IRC, he wanted me to check for all-null 
returns, so you probably should check if the IP address is 0.0.0.0 (or :: for 
IPv6), too.

Also, I had the impression that the Wine convention was that case block braces 
go onto a new line, too. You might want to consider that for the switch you 
addded.

Thanks for doing the work for me otherwise :)

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://us1.samba.org/samba/team/
--
Will code for cotton.

[Attachment #5 (application/pgp-signature)]



[prev in list] [next in list] [prev in thread] [next in thread]