[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: dsound: PrimarySetFormat patch,
From:       Chris Robinson <chris.kcat () gmail ! com>
Date:       2007-04-30 18:29:07
Message-ID: 200704301129.08636.chris.kcat () gmail ! com
[Download RAW message or body]

On Monday 30 April 2007 04:15:41 am Dylan Taft wrote:
> +       if (wfex->nChannels > 2) {
> +                FIXME("Currently only supports 2 channels, returning
> DSERR_BADFORMAT. (requested channels=%d)\n",wfex->nChannels);
> +                return DSERR_BADFORMAT;
> +       }

The function is not supposed to fail if it's trying to set an unsupported 
format with a priority level of DSSCL_PRIORITY. It should instead just set 
the closest possible.

The function *should*, however, fail like that if using the DSSCL_WRITEPRIMARY 
priority level.


[prev in list] [next in list] [prev in thread] [next in thread]