[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Jason Edmeades : xcopy: Add support for COPYCMD override and
From:       "Ann & Jason Edmeades" <us () edmeades ! me ! uk>
Date:       2007-03-30 19:48:55
Message-ID: 002101c77304$764f2430$1001a8c0 () JasonsPC
[Download RAW message or body]

>wouldn't it be nicer to use sizeof(copyCmd) here?
>if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) {
>There are many spots like this in wcmdmain.c 

Yes... I'm blaming cut and paste as I didn't do all the wcmd ones :-)

Once I get all my xcopy patches in I want to continue my rework of the cmd
commands, finishing off some more inbuilt ones which I know are broken. I
also want to extend your last patch to ensure all parts which process a
command line are using the MAXSTRING length, and I'll do a patch for this
while I am at it.

Thanks,
Jason




[prev in list] [next in list] [prev in thread] [next in thread]