[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: winex11.drv: Remove an unnecessary XFlush().
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2007-03-30 8:54:47
Message-ID: 87vegjyuug.fsf () wine ! dyndns ! org
[Download RAW message or body]

Huw Davies <huw@codeweavers.com> writes:

> --- a/dlls/winex11.drv/xrender.c
> +++ b/dlls/winex11.drv/xrender.c
> @@ -596,7 +596,6 @@ void X11DRV_XRender_UpdateDrawable(X11DRV_PDEVICE *physDev)
> if(physDev->xrender->pict)
> {
> TRACE("freeing pict = %lx dc = %p\n", physDev->xrender->pict, physDev->hdc);
> -        XFlush(gdi_display);
> pXRenderFreePicture(gdi_display, physDev->xrender->pict);
> physDev->xrender->pict = 0;
> }

This causes a test failure here:

../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so \
header.c && touch header.ok X Error of failed request:  BadPixmap (invalid Pixmap \
parameter)  Major opcode of failed request:  54 (X_FreePixmap)
  Resource id in failed request:  0x2400023
  Serial number of failed request:  461
  Current serial number in output stream:  472
make: *** [header.ok] Error 1

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]