[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Resend: user32: fix return value in DialogBoxParamA if no
From:       "Dmitry Timoshkov" <dmitry () codeweavers ! com>
Date:       2006-12-31 17:46:57
Message-ID: 006401c72d04$3ad3d9f0$0100a8c0 () DMITRY
[Download RAW message or body]

"Louis. Lenders" <xerox_xerox2000@yahoo.co.uk> wrote:

> As Dmitry Timoshkov (thanks for that) the SetLastError was not necessary.
> Here's updated patch.

Probably the problem is that you need also handle both FindResourceW and
LoadResource failures the same way by returning -1, and change 'return -1;'
later to 'return 0;' (for invalid parent) as MSDN suggests. All that needs
to be tested as well. Also DialogBoxParamW needs to be fixed as well.

Probably other dialaog APIs (like DialogBoxIndirectParamAorW) need a review
regarding that.

-- 
Dmitry.



[prev in list] [next in list] [prev in thread] [next in thread]