[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: usp10: Resend - Add funtionality for ScriptStringAnalyse
From:       Hans Leidekker <hans () it ! vu ! nl>
Date:       2006-07-30 8:09:06
Message-ID: 200607301009.07059.hans () it ! vu ! nl
[Download RAW message or body]

On Sunday 30 July 2006 09:30, Jeff L wrote:

> +    Script_string_analysis *pScript_str_analysis;
> +    void *pAnalysis_ptrstr;

Uniscribe is about scripts, so why not leave off these 'Script' prefixes?
Furthermore, I think encoding the type in the variable name is redundant,
you get that information from reading the declaration. Also, the void pointer
variable is not needed, you can cast *pssa straight away. So, what about
something like this instead?:

    string_analysis *analysis;

 -Hans


[prev in list] [next in list] [prev in thread] [next in thread]