[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [AppDb] update the comments in some files
From:       Jonathan Ernst <jonathan () ernstfamily ! ch>
Date:       2006-06-30 6:02:59
Message-ID: 1151647379.27105.3.camel () localhost
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le jeudi 29 juin 2006 à 12:43 -0400, Chris Morgan a écrit :
> Why not replace the require_once() with requires instead of putting it on the 
> todo?

Because we have to check that it nevers poses a problem (for example if
the file is included elsewhere), so that's another patch entierly.

> We don't really need the $aClean TODO item since thats high on the priority 
> list at the moment and we'll just end up removing it in a day or two right?

i don't like to rediff it, we'll have to remove the aClean one by one to
be sure that it's not posing problems too so that we can remove the todo
elements one by one in the files.

> 
> The move of show_note() into its class is on my todo list for class cleanups 
> today or tomorrow as well.  

Excellent, you'll remove the todo item at the same time then.

> 
> Basically I think we can do without the todo notes for now since most of it is 
> in the process of being fixed.  The rest of the comments look good though.

Please don't refuse this patch because of this, I don't want to rediff
it...

Thanks 


["signature.asc" (application/pgp-signature)]



[prev in list] [next in list] [prev in thread] [next in thread]