[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: getuname: add stub implementation [try 2]
From:       Robert Shearman <rob () codeweavers ! com>
Date:       2006-05-31 12:56:12
Message-ID: 447D926C.2070005 () codeweavers ! com
[Download RAW message or body]

Vitaly Lipatov wrote:

>+/***********************************************************************
>+ *             GetUName [ 2000 / XP ]
>+ *
>+ * undocumented fn: GetUName()
>+ * The information is not available by API. The thing MS did 
>+ * here -- parsing the data from nameslist.txt in the Unicode Character 
>+ * Database (UCD).
>+ * See
>+ *  http://groups.google.com/groups?hl=en&threadm=ODVecQBoBHA.2416%40tkmsftngp02
>+ * RETURNS
>+ *  unknown
>+ */
>+void WINAPI GetUName(void)
>+{
>+	FIXME("stub\n");
>+}
>  
>

You should add a test for this function and document at least the number 
of parameters of the function. Presumably it should take some parameters 
or return something, or the DLL is useless. If the former is incorrect 
then the stack will be trashed after the call.

-- 
Rob Shearman



[prev in list] [next in list] [prev in thread] [next in thread]