[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: advpack: Forward ExecuteCabA to its unicode counterpart
From:       Robert Shearman <rob () codeweavers ! com>
Date:       2006-03-30 12:55:46
Message-ID: 442BD552.8070908 () codeweavers ! com
[Download RAW message or body]

James Hawkins wrote:

>@@ -86,6 +87,43 @@ HRESULT WINAPI DoInfInstall(const SETUPC
> 
> /***********************************************************************
>  *             ExecuteCabA    (ADVPACK.@)
>+ *
>+ * See ExecuteCabW.
>+ */
>+HRESULT WINAPI ExecuteCabA(HWND hwnd, CABINFOA* pCab, LPVOID pReserved)
>+{
>+    UNICODE_STRING cab, inf, section;
>+    CABINFOW cabinfo;
>+    HRESULT hr;
>+
>+    TRACE("(%p, %p, %p)\n", hwnd, pCab, pReserved);
>+
>+    if (!pCab)
>+        return E_INVALIDARG;
>+
>+    RtlCreateUnicodeStringFromAsciiz(&cab, pCab->pszCab);
>  
>

pCab->pszCab can be NULL, right? I don't think 
RtlCreateUnicodeStringFromAsciiz handles that case in the way you expect.

-- 
Rob Shearman



[prev in list] [next in list] [prev in thread] [next in thread]