[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: advpack: Open the INF file if the RSC_FLAG_INF flag is specified
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2006-03-29 12:06:30
Message-ID: 87mzf9316h.fsf () wine ! dyndns ! org
[Download RAW message or body]

"James Hawkins" <truiken@gmail.com> writes:

> @@ -72,10 +72,7 @@ static void test_RunSetupCommand()
> /* try to run an exe with the RSC_FLAG_INF flag */
> hexe = (HANDLE)0xdeadbeef;
> hr = pRunSetupCommand(NULL, "winver.exe", "Install", "c:\\windows\\system32", \
>                 "Title", &hexe, RSC_FLAG_INF, NULL);
> -    todo_wine
> -    {
> -        ok(hr == SPAPI_E_WRONG_INF_STYLE, "Expected SPAPI_E_WRONG_INF_STYLE, got \
>                 %ld\n", hr);
> -    }
> +    ok(hr & SPAPI_E_EXPECTED_SECTION_NAME, "Expected a setupapi error, got %ld\n", \
> hr);

This test doesn't make sense. If you want to test certain bits you
have to write that explicitly, not pick some random constant that
happens to have the right value. And in any case a simple AND won't do
what you want.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]