[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: x11drv fix for bug#4506:  page fault on read access
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2006-02-28 11:38:13
Message-ID: 87fym3emsa.fsf () wine ! dyndns ! org
[Download RAW message or body]

Rein Klazes <wijn@wanadoo.nl> writes:

> Fixing bug #4506: unaligned 32bit access, can access one byte beyond the
> pixel buffer.
>
> Changelog:
> dlls/x11drv	: dib_convert.c
> Avoid unaligned 32 bit reads, and reads beyond the input pixel buffer in
> the convert_888_to_0888_* functions.

This will badly hurt performance, you don't want to check alignment on
every pixel. You should only check on the first one and copy 1 to 3
pixels as needed to align things properly, then do the 4 pixels at a
time thing.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]