[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: OLEAUT32: Use the FAILED macro to check for failure of interface
From:       Robert Shearman <rob () codeweavers ! com>
Date:       2005-12-31 10:54:50
Message-ID: 43B6637A.4080609 () codeweavers ! com
[Download RAW message or body]

Marcus Meissner wrote:

>On Sat, Dec 31, 2005 at 11:12:33AM +0900, Mike McCormack wrote:
>  
>
>>Robert Shearman wrote:
>>
>>    
>>
>>>These changes are wrong. IStream_Read can return S_FALSE, which means 
>>>that the call was successful, but didn't do what was intended. From MSDN:
>>>
>>>S_FALSE
>>>  The data cannot be read from the stream object. Depending on the
>>>  implementation, either S_FALSE or an error code could be returned
>>>  when reading past the end of the stream.
>>>      
>>>
>>Fair enough.   Then perhaps the ole storage code is broken, because it 
>>returns S_FALSE when it correctly read the requested amount of data, and 
>>IOlePicture_Load was failing to read a bitmap from an MSI package.
>>    
>>
>
>Do you have a testcase installer?
>

No need. Working with Mike, I've found the bug and I'll send a patch soon.

-- 
Rob Shearman



[prev in list] [next in list] [prev in thread] [next in thread]