[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Preliminary CD-Rom support on MacOS X #2
From:       emmanuel maillard <e.rsz () libertysurf ! fr>
Date:       2005-12-30 18:10:44
Message-ID: 7B1C2131-1BBB-484B-A059-277CB6CA045E () libertysurf ! fr
[Download RAW message or body]

Hi,

Thanks for the comment, i agree with it but i was thinking than  
keeping separated patches was better than (in this case)
merging  #2 + #3 + #5 in a big patch.

Any tricks are welcome.

Thanks

Emmanuel

Le 30 déc. 05 à 13:08, Robert Shearman a écrit :

> emmanuel maillard wrote:
>
>> Changelog :
>>     kernel/proces.c : Initialize darwin removable devices
>
>
> I appreciate you splitting up your patches for easier review, but  
> patches are meant to be independent atomic changes that improve the  
> code. However, if Alexandre applied this patch alone then Wine  
> wouldn't compile any more and this isn't acceptable.
>
> -- 
> Rob Shearman
>
>
>




[prev in list] [next in list] [prev in thread] [next in thread]