[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Fix ntdll compilation in Darwin
From:       "Dmitry Timoshkov" <dmitry () baikal ! ru>
Date:       2005-06-30 14:04:04
Message-ID: 001d01c57d7c$db6ae680$cc823bd5 () boss
[Download RAW message or body]

"Phil Krylov" <phil@newstar.rinet.ru> wrote:

>> > #ifdef SENSEBUFLEN
>> >     if (pPacket->SenseInfoLength > SENSEBUFLEN)
>> > +#elif defined( __APPLE__ )
>> > +    if (pPacket->SenseInfoLength > kSenseDefaultSize)
>> > #else
>> >     if (pPacket->SenseInfoLength > sizeof(struct request_sense))
>> > #endif
>> 
>> Please do not introduce even more platform dependent #ifdefs into cdrom.c,
>> currently it already has enough mess with all that #if defined(linux)/(__FreeBSD__)/
>> (__NetBSD__). Add proper configure checks for headers and structures your
>> platform needs.
> 
> To be sure I get you right: would changing __APPLE__ to HAVE_IOKIT (and
> adding HAVE_IOKIT detection to configure) be sufficient?

I'd assume it's enough, yes. kSenseDefaultSize requires another test I think.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]