[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [MSXML] : add declarations for XMLDOM
From:       Mike McCormack <mike () codeweavers ! com>
Date:       2005-06-30 8:06:50
Message-ID: 42C3A81A.9080602 () codeweavers ! com
[Download RAW message or body]


Hi Vijay,

Vijay Kiran Kamuju wrote:
> I am sending a new patch for th XMLDOM stuff
> ChangeLog
> ----------------
> add definitions and declarations for XMLDOM stuff

Thanks for sending the patch in.  After looking through it, here are my 
notes:

* try cut it up into small bits, the smaller the better.  Alexandre 
checks every line before applying a patch, so if you reduce the size of 
you patches, you'll reduce Alexandre's work and increase the chance that 
they go into Wine.  So I'd suggest cut this patch up into two patches, 
one to add the DISPIDs and one to add the interface code.

* you should add your own copyright line, instead of adding to the end 
of mine. eg.

    * Copyright (C) 2005 Mike McCormack
    * Copyright (c) 2005 Vijay Kiran Kamuju

looks like good,

Mike

[prev in list] [next in list] [prev in thread] [next in thread]