[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ntdll: Fix add_access_ace
From:       Mike McCormack <mike () codeweavers ! com>
Date:       2005-06-30 3:49:00
Message-ID: 42C36BAC.9090009 () codeweavers ! com
[Download RAW message or body]


Hi James,

James Hawkins wrote:

> These changes make the advapi32 tests pass as well.
> 
> Changelog
> * Fix calculation of generic pointers.
> * Minor cleanups.

Thanks for the fixes.  This makes Office 2003 work again for me.

>      if ((DWORD)(pAceHeader + dwAceSize) > (DWORD)(pAcl + pAcl->AclSize))
>          return STATUS_ALLOTTED_SPACE_EXCEEDED;

I think you might have missed one here.  The above pointer arithmetic 
seems like it will make the wrong calculation.  Maybe something like the 
following would work better:

   if ( &((char*)pAceHeader)[dwAceSize] > &((char*)pAcl)[pAcl->AclSize] )

Mike

[prev in list] [next in list] [prev in thread] [next in thread]