[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [ddraw] Mipmap creation with DDSCAPS_COMPLEX, DDSCAPS_MIPMAP, and no mipmap count
From:       Antoine Chavasse <a.chavasse () gmail ! com>
Date:       2005-05-29 19:10:08
Message-ID: be8477c05052912105c5459d6 () mail ! gmail ! com
[Download RAW message or body]

Mike Hearn <mh@codeweavers.com> wrote:
> I can't comment on the DirectX side of things, but this looks like a
> textbook case of how to do a patch correct.

Thanks :)


On 5/29/05, Lionel Ulmer <lionel.ulmer@free.fr> wrote:

> 
> The only (minor) gripe I would have with this patch is the use of the 'log()
> / log()' to compute the mipmap count (I usually dislike floating point match
> - it's maybe my background in embedded programming where FPU are inexistant
> :-) )... I would have found it simpler to just have a 'while (min > 0) { min
> >>= 1; count += 1 }'.
> 

Alright. I'll resend the patch with this change.


[prev in list] [next in list] [prev in thread] [next in thread]