[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ITSS: DllCanUnloadNow implementation
From:       Robert Shearman <rob () codeweavers ! com>
Date:       2004-12-31 1:28:08
Message-ID: 41D4AB28.7020606 () codeweavers ! com
[Download RAW message or body]

Jacek Caban wrote:

> Changelog:
>    Implemented DllCanUnloadNow


> 
> BOOL WINAPI ITSS_DllCanUnloadNow(void)
> {
>-    FIXME("\n");
>-
>-    return FALSE;
>+    TRACE("dll_count = %lu\n", dll_count);
>+    return !dll_count;
>  
>

This function should return an HRESULT, not a BOOL. This error would 
have been caught if it weren't for the silly ITSS_ prefix. Consequently, 
the return value should be either S_OK or S_FALSE depending on whether 
there are no or some remaining references respectively.

Rob

[prev in list] [next in list] [prev in thread] [next in thread]