[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    RE: patch: shell32.dll - SHELL_ArgifyW expands env-vars
From:       Steven Edwards <steven_ed4153 () yahoo ! com>
Date:       2004-08-29 19:00:06
Message-ID: 20040829190006.34462.qmail () web21122 ! mail ! yahoo ! com
[Download RAW message or body]

Hi Jens,

--- Jens Collin <jens.collin@lakhei.com> wrote:
> Is there anything wrong with this patch? I can't see my changes taken
> place in CVS.
> Let me know and I'll fix 'em.

I looks like it might be because of indenting tabs/spaces and C++ style
comments.

This 

     PWSTR   res = out;
     PCWSTR  cmd;
     LPVOID  pv;
+    WCHAR	tmpBuffer[1024];
+	PWSTR	tmpB = tmpBuffer;
+	WCHAR	tmpEnvBuff[MAX_PATH];
+	WCHAR*	tmpE = tmpEnvBuff;
+	DWORD	envRet;

and this

+	    // Make sure that we have at least one more %.


Thanks
Steven



		
_______________________________
Do you Yahoo!?
Win 1 of 4,000 free domain names from Yahoo! Enter now.
http://promotions.yahoo.com/goldrush

[prev in list] [next in list] [prev in thread] [next in thread]