[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: add autodetect audio driver capability to winmm, second try
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2004-07-29 23:04:06
Message-ID: 87llh22z6h.fsf () mail ! wine ! dyndns ! org
[Download RAW message or body]

James Hawkins <truiken@gmail.com> writes:

> +    /* try to detect arts */
> +    argv_new[2] = "ps awx|grep artsd|grep -v grep|grep artsd > /dev/null";
> +    if(!spawnvp(_P_WAIT, "/bin/sh", argv_new))
> +    {
> +        driversFound[numFound] = "winearts.drv";
> +        name[numFound] = "aRts";
> +        numFound++;
> +    }

This code does not belong in winmm. Autodetection in winmm should be
done by having the drivers themselves fail to load if the
corresponding support is missing.

-- 
Alexandre Julliard
julliard@winehq.org

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic