[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: dbghelp crashes
From:       Eric Pouech <pouech-eric () wanadoo ! fr>
Date:       2004-06-27 8:51:54
Message-ID: 40DE8AAA.2040007 () wanadoo ! fr
[Download RAW message or body]

Jon Griffiths a écrit :
> Hi,
> 
> Some overly long stabs cause crashes when debug tracing is enabled.
> 
> Cheers,
> Jon
> 
>    +dlls/dbghelp/stabs.c
>    Prevent the debug buffer from overflowing on long stabs
You shouldn't use debugstr_an with a fixed value, since all strings are 
'\0' terminated.
Either fix dlls/ntdll/debugtools.c to handle properly those long string 
conditions (and remove the ugly call to abort()), or use min(256, 
strlen(ptr)) as the actual length of the string in debugstr_an calls.
I'd prefer the first solution.
A+

[prev in list] [next in list] [prev in thread] [next in thread]