[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Add a test case and a fix for the window styles state at the window creation time
From:       Bill Medland <billmedland () mercuryspeed ! com>
Date:       2004-01-30 17:49:07
Message-ID: 200401300949.07921.billmedland () mercuryspeed ! com
[Download RAW message or body]

On January 30, 2004 08:08 am, Dmitry Timoshkov wrote:
> Hello,
>
> Changelog:
>     Dmitry Timoshkov <dmitry@codeweavers.com>
>     Add a test case and a fix for the window styles state
>     at the window creation time.
>

SNIP

> +            cs->style |= WS_CAPTION;
> +            wndPtr->flags |= WIN_NEED_SIZE;
> +	}
> +    }
> +
>      /* Fill the window structure */
>
>      wndPtr->tid            = GetCurrentThreadId();

SNIP

The problem with comments is that they don't get maintained.

I suggest that this is one of those
"x=x+1; /* increment x */" 
type comments and the comment should go too.

(If it is not clear to anyone, the comment suggests that below the comment is 
where the structure gets filled in and the casual observer won't notice that 
one element was actually done before the comment).

Bill
-- 
Bill Medland
mailto:billmedland@mercuryspeed.com
http://webhome.idirect.com/~kbmed


[prev in list] [next in list] [prev in thread] [next in thread]