[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: shlwapi: optimise path functions
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2003-11-30 2:01:40
[Download RAW message or body]

"Dimitrie O. Paun" <dpaun@rogers.com> writes:

> Well, I'm not sure this is worth doing. First off, we're not fixing any
> app that makes use of CharNext{A,W}(). Second, why is your static method
> any faster than the real CharNextA()? Third, it's not correct to replace
> CharNextW() with an array increment. While it is true that currently our
> CharNextW() simply does the same thing, it should be fixed in the long
> run to properly deal with Unicode Surrogate Pairs:

While that's true in general, for the path functions it doesn't really
matter since surrogates will never be path separators, so getting rid
of CharNextW in that case is OK. CharNextA is another story however...

-- 
Alexandre Julliard
julliard@winehq.com

[prev in list] [next in list] [prev in thread] [next in thread]