[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Small Fix
From:       "Nix N. Nix" <nix () go-nix ! ca>
Date:       2002-06-26 20:36:05
[Download RAW message or body]

On Wed, 2002-06-26 at 16:04, Nix N. Nix wrote:
> ChangeLog:
> 
> dlls/shell32/dialogs.c:FillList:
> Removed a MessageBox
> This MessageBox would pop up if a RunMRU list was not found.  Instead,
> it should /silently/ start a new MRUList.
> 
> dlls/shell32/dialogs.c:RunDlgProc:
> Removed dumb comment
> I must've put that comment there just before going to bed (=> brain was
> liquefied at the time).
> 
> Sorry I didn't spot these earlier.
> 
> 


["RunFileDlg2.diff" (RunFileDlg2.diff)]

Index: dlls/shell32/dialogs.c
===================================================================
RCS file: /home/wine/wine/dlls/shell32/dialogs.c,v
retrieving revision 1.6
diff -u -r1.6 dialogs.c
--- dlls/shell32/dialogs.c	10 Jun 2002 02:34:36 -0000	1.6
+++ dlls/shell32/dialogs.c	26 Jun 2002 20:03:00 -0000
@@ -234,8 +234,6 @@
             return TRUE ;
             }
         }
-        
-    /* This should be DefDlgProcA, but that doesn't work */
     return FALSE ;
     }
 
@@ -255,8 +253,8 @@
         0, "", REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL, &hkey, NULL))
         MessageBoxA (hCb, "Unable to open registry key !", "Nix", MB_OK) ;
         
-    if (ERROR_SUCCESS != RegQueryValueExA (hkey, "MRUList", NULL, NULL, NULL, &icList))
-        MessageBoxA (hCb, "Unable to grab size for MRUList !", "Nix", MB_OK) ;
+    RegQueryValueExA (hkey, "MRUList", NULL, NULL, NULL, &icList) ;
+
     if (icList > 0)
         {
         pszList = malloc (icList) ;


[prev in list] [next in list] [prev in thread] [next in thread]