[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-cvs
Subject:    =?UTF-8?Q?Zebediah_Figura_=3A_winegstreamer=3A_Don=27t_grab_filter=5Fcs_i?= =?UTF-8?Q?n_activate=5Fp
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2021-01-29 21:10:21
Message-ID: E1l5b25-0003t7-4o () winehq ! org
[Download RAW message or body]

Module: wine
Branch: master
Commit: 8e84f16066568e1a24f6eff1a8137acfe4f68ed2
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=8e84f16066568e1a24f6eff1a8137acfe4f68ed2

Author: Zebediah Figura <z.figura12@gmail.com>
Date:   Thu Jan 28 18:40:14 2021 -0600

winegstreamer: Don't grab filter_cs in activate_push().

There's no good reason to do this; we're not protecting anything that isn't
already protected by GStreamer locks.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

---

 dlls/winegstreamer/gstdemux.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
index b2a20934837..e7178bb4dfc 100644
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -1421,7 +1421,6 @@ static gboolean activate_push(GstPad *pad, gboolean activate)
 {
     struct parser *This = gst_pad_get_element_private(pad);
 
-    EnterCriticalSection(&This->filter.filter_cs);
     if (!activate) {
         TRACE("Deactivating\n");
         if (This->push_thread) {
@@ -1441,7 +1440,6 @@ static gboolean activate_push(GstPad *pad, gboolean activate)
             return FALSE;
         }
     }
-    LeaveCriticalSection(&This->filter.filter_cs);
     return TRUE;
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]