[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wikitech-l
Subject:    [Wikitech-l] Re: Feedback wanted: PHPCS in a static types world
From:       Niklas_Laxström <niklas.laxstrom () gmail ! com>
Date:       2022-10-28 14:15:10
Message-ID: CAAVd=jYHsz2JpwRdnOQ5eUhyg_qGDjSmq9RikMTqfbFj++9KkQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


pe 28. lokak. 2022 klo 17.04 Lucas Werkmeister (
lucas.werkmeister@wikimedia.de) kirjoitti:

> In my opinion, MediaWiki's PHPCS ruleset feels largely rooted in an older
> version of PHP, where static type declarations (formerly known as "type
> hints") did not exist. As we move towards more modern code, I think some
> rules should be relaxed, and others adjusted. More specifically, I'd like
> to know if most people agree with the following propositions and conclusion:
> 

I support relaxing the phpcs rules by default. We have already disabled
some of these rules for new code in the Translate extension (ref
<https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Translate/+/refs/heads/master/.phpcs.xml#27>)
 with the same reasoning you gave.

  -Niklas


[Attachment #5 (text/html)]

<div dir="ltr"><div dir="ltr">pe 28. lokak. 2022 klo 17.04 Lucas Werkmeister (<a \
href="mailto:lucas.werkmeister@wikimedia.de">lucas.werkmeister@wikimedia.de</a>) \
kirjoitti:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>In my opinion, MediaWiki's \
PHPCS ruleset feels largely rooted in an older version of PHP, where static type \
declarations (formerly known as "type hints") did not exist. As we move towards more \
modern code, I think some rules should be relaxed, and others adjusted. More \
specifically, I'd like to know if most people agree with the following propositions \
and conclusion:<br></div></div></blockquote><div><br></div><div>I support relaxing \
the phpcs rules by default. We have already disabled some of these rules for new code \
in the Translate extension (<a \
href="https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Translate/+/refs/heads/master/.phpcs.xml#27">ref</a>) \
with the same reasoning you  gave.</div><div><br></div><div>   \
-Niklas</div></div></div>



_______________________________________________
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-leave@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[prev in list] [next in list] [prev in thread] [next in thread]