[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wikitech-l
Subject:    Re: [Wikitech-l] QUnit, Promises and ArticlePlaceHolder
From:       Derk-Jan Hartman <d.j.hartman+wmf_ml () gmail ! com>
Date:       2018-07-23 13:00:10
Message-ID: CABytgG8XsfnqzCieMvpJqtBu53NpOgMZxRm8qNNzSxSD3+NReA () mail ! gmail ! com
[Download RAW message or body]

Well following the trail of links, leads me to this likely cause:
https://phabricator.wikimedia.org/T180171#4236340

The extension relies on grunt-contrib-qunit which depends on
> phantomjs-prebuild and run qunit tests with PhantomJS. The tests are under
> tests/qunit:


which indirectly is triggered by hashar's work on quibble I presume.

DJ

On Sat, Jul 21, 2018 at 6:05 PM Aleksey Bekh-Ivanov <
aleksey.bekh-ivanov@wikimedia.de> wrote:

> Hi!
>
> Why did you start working on that? (Task description says nothing about the
> reason)
>
> I express my personal opinion here:
> I would like it to stay like it is (running in nodejs) - it is far more
> developer friendly to run nodejs tests than Special:JavaScriptTest.
> And, to be honest, I would want to migrate more JS test code supported by
> WMDE to nodejs.
>
>
> On 21 July 2018 at 00:13, Antoine Musso <hashar+wmf@free.fr> wrote:
>
> > Hello,
> >
> > The ArticlePlaceholder extension has QUnit tests run via nodejs.  I am
> > trying to port them to Special:JavaScriptTest.
> >
> > I am hitting a wall due to an OOUi widget not being found on the first
> > test.  Most probably because the window is opened asynchronously and the
> > assertions are run before it opens.
> >
> > JavaScript Promises are not my thing and I know nothing about OOUi.  If
> > that is in your area of expertise, I could use a hand to finish up the
> > port:
> >
> > https://gerrit.wikimedia.org/r/#/c/444936/6
> >
> > Thank you!
> >
> >
> > --
> > Antoine "hashar" Musso
> >
> >
> >
> >
> > _______________________________________________
> > Wikitech-l mailing list
> > Wikitech-l@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[prev in list] [next in list] [prev in thread] [next in thread]