[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wikitech-l
Subject:    Re: [Wikitech-l] [MediaWiki-CVS] SVN: [37980]
From:       "Guy Van den Broeck" <guyvdb () gmail ! com>
Date:       2008-07-24 1:05:30
Message-ID: 3f58d4fa0807231805u63cd2fb4paeeb0abb3c71457a () mail ! gmail ! com
[Download RAW message or body]

Thanks for the suggestion. Unfortunatly when I'm diffing big datasets
I'm iterating the same loop half a million times. I just can't have
the overhead of even a function call when I'm optimizing that code for
speed. This is the easiest way for me to switch between debugging and
optimizing.

I'll make sure the comments are cleaner next time I commit.

2008/7/24 Simetrical <Simetrical+wikilist@gmail.com>:
> On Wed, Jul 23, 2008 at 6:41 PM,  <guyvdb@svn.wikimedia.org> wrote:
>> -               ////echo "<br>$delta, $p";
>> +               //////echo "<br>$delta, $p";
>
>> -               ////echo "<br>$x_start-$x_end , $y_start-$y_end";
>> +               //////echo "<br>$x_start-$x_end , $y_start-$y_end";
>
>> -                       ////echo "-pass";
>> +                       //////echo "-pass";
>
>> [tons more in this vein]
>
> If your goal here is debugging, I would suggest that you use wfDebug()
> instead of trying to search-and-replace commented-out echoes
> constantly (I'm assuming that's what you're doing).  Especially if
> you're going to accidentally change the number of slashes in dozens of
> lines of comments and make the diffs unreadable.
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[prev in list] [next in list] [prev in thread] [next in thread]