[prev in list] [next in list] [prev in thread] [next in thread] 

List:       whonix-devel
Subject:    Re: [Whonix-devel] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory
From:       "Tor Bug Tracker & Wiki" <blackhole () torproject ! org>
Date:       2019-02-20 23:31:12
Message-ID: 058.9339f4b58fe3f95614ff4d5588416380 () torproject ! org
[Download RAW message or body]

--===============3920736784693922535==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

#25140: Parse only .torrc files in torrc.d directory
-------------------------------------------------+-------------------------
 Reporter:  iry                                  |          Owner:
                                                 |  Jigsaw52
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Major                                |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  035-removed-20180711                           |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by Jigsaw52):

 * status:  needs_revision => needs_review


Comment:

 I agree but the tor_glob function was changed by a later commit.

 After developing get_glob_opened_files in commit
 111ec3ebd5c6cf4b46344f98a1b78b12dcabdf6a
 (https://github.com/torproject/tor/pull/489/commits/111ec3ebd5c6cf4b46344f98a1b78b12dcabdf6a),
 the Windows version of tor_glob ended up sharing much of the code with
 get_glob_opened_files (due to both needing to expand path components with
 globs manually). Because of that, all the common code has been split into
 smaller functions in commit c5883f356f92aca478450f0e09d6caac53ce2085
 (https://github.com/torproject/tor/pull/489/commits/c5883f356f92aca478450f0e09d6caac53ce2085).

 I think it might be easier to review this pull request code by looking at
 the diff for the whole pull request (the files changed tab in github).
 I've avoided squashing the first 4 commits because they were already
 reviewed in
 https://trac.torproject.org/projects/tor/ticket/25140#comment:19 but I now
 wish I hadn't as the pull request would be easier to read if they had been
 squashed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25140#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

--===============3920736784693922535==--

[Attachment #3 (text/plain)]

_______________________________________________
You are receiving this e-mail because you subscribed Whonix-devel mailing list. To \
unsubscribe visit https://www.whonix.org/cgi-bin/mailman/listinfo/whonix-devel or \
mail "unsubscribe" to Whonix-devel-unsubscribe@whonix.org.

Sie erhalten diese E-Mail, weil Sie die Whonix-devel Mailingliste aboniert haben. Zum \
abbestellen besuchen Sie https://www.whonix.org/cgi-bin/mailman/listinfo/whonix-devel \
oder mailen Sie "unsubscribe" an Whonix-devel-unsubscribe@whonix.org.



[prev in list] [next in list] [prev in thread] [next in thread]